Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix analytics handling when core/cask taps are untapped #14635

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Fix analytics handling when core/cask taps are untapped #14635

merged 1 commit into from
Feb 15, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Feb 15, 2023 •
edited

After untapping a cask tap with API mode enabled, cask installs would end in an error:

Error: No available tap homebrew/cask.
/usr/local/Homebrew/Library/Homebrew/tap.rb:219:in `config'
/usr/local/Homebrew/Library/Homebrew/tap.rb:737:in `read_or_set_private_config'
/usr/local/Homebrew/Library/Homebrew/tap.rb:213:in `private?'
/usr/local/Homebrew/Library/Homebrew/cask/installer.rb:113:in `install'
/usr/local/Homebrew/Library/Homebrew/cask/cmd/install.rb:110:in `block in install_casks'
/usr/local/Homebrew/Library/Homebrew/cask/cmd/install.rb:109:in `each'
/usr/local/Homebrew/Library/Homebrew/cask/cmd/install.rb:109:in `install_casks'
/usr/local/Homebrew/Library/Homebrew/cmd/install.rb:185:in `install'
/usr/local/Homebrew/Library/Homebrew/brew.rb:93:in `<main>'

When installing a formula from homebrew-core with the core tap untapped, analytics data would never be reported.

This PR fixes this.

@Bo98 Bo98 added critical Critical change which should be shipped as soon as possible. install from api Relates to API installs labels Feb 15, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

MikeMcQuaid
MikeMcQuaid approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @Bo98

@MikeMcQuaid MikeMcQuaid merged commit 56adf8c into Homebrew:master Feb 15, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. install from api Relates to API installs outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Bo98 @BrewTestBot @MikeMcQuaid